[et-mgmt-tools] [PATCH] convert vmware machines to virt-image xml format

Daniel P. Berrange berrange at redhat.com
Thu Jun 26 15:19:01 UTC 2008


On Thu, Jun 26, 2008 at 11:10:29AM -0400, Cole Robinson wrote:
> > +def parse_args():
> > +    parser = OptionParser()
> > +    parser.set_usage("%prog [options] image.vmx")
> > +    parser.add_option("-a", "--arch", type="string", dest="arch",
> > +                      help=("Machine Architecture Type (i686/x86_64/ppc)"))
> > +    parser.add_option("-t", "--type", type="string", dest="type",
> > +                      help=("Output virtualization type (hvm, paravirt"))
> 
> For type I would use the convention that virt-install uses: add seperate
> options for --paravirt and --hvm (optionally -p or -v). Also I'd recommend
> just defaulting to --hvm since that is the most common case at this point.

Yes, keeping consistent naming of CLI args across all the virt-XXX tools
is very important - even if some of our existing naming is a little odd :-)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the et-mgmt-tools mailing list