[et-mgmt-tools] Re-usage of existing disks/virt-install

[Daniel P. Berrange]

On Wed, Mar 05, 2008 at 04:53:41PM -0500, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Wed, Feb 20, 2008 at 10:02:27AM -0500, Cole Robinson wrote:
> >> Alexander Todorov wrote:
> >>> -----BEGIN PGP SIGNED MESSAGE-----
> >>> Hash: SHA512
> >>>
> >>> Hello,
> >>> I've been using a shell script to help me with some testing which installs the
> >>> same Xen guest over and over again. Now I've noticed that in
> >>> python-virtinst-0.300.2-3.fc8 there's new functionality. virt-install will check
> >>> if the file exists and ask to overwrite, then it will ask if you want to use the
> >>> same file if it's being used by another guest (in my case inactive).
> >>>
> >>> That's breaking the cli by making it interactive. This has impact on old scripts
> >>> which do not require further interaction.
> >>>
> >>> Can we consider a --yes or a similar option to deal with this problem?
> >>> Any opinions are welcome.
> >>>
> >>> Thanks,
> >>> Alexander.
> >> Complete agreement here, I actually cooked up something similar to this a while
> >> ago and posted it to the list, but never committed it. There should probably
> >> be an option to answer yes where applicable, but also an option to outright fail
> >> on any prompt.
> >>
> >> Something like --noprompt={fail,yes}, defaults to fail. Unfortunately this doesn't
> >> look very intuitive but my brain isn't thinking of anything cleaner at the moment.
> > 
> > Personally I think the check for a file existing on disk is an utter waste
> > of time & just serves to seriously annoy & should be removed. Fine checking
> > for it being in use in an existing guest though.
> > 
> > The -f, or --force is the common nomenculture used to rm/cp/mv to stop it
> > prompting
> > 
> > Dan.
> 
> The file check is now gone upstream, but a --force option is still a good idea.

ACK, this patch gets my vote.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|