[et-mgmt-tools] [PATCH] Save on separate connection
Daniel P. Berrange
berrange at redhat.com
Mon Mar 24 02:28:18 UTC 2008
On Sun, Mar 23, 2008 at 09:54:47PM +0100, Soren Hansen wrote:
> Here's another patch I've been neglecting to forward. :(
>
> Requests to kvm to save its state is sent from a different thread, but
> on the same connection as any other communication with the relevant
> libvirtd instance. This has a good chance of causing responses to come
> back out of order, and that makes libvirt cry. :(
>
> This patch creates a separate connection for the save operation. I'm
> almost sure it's not correct, but it seems to do the job. :)
Rather that creating a full vmmConnection() object, I think its a little
simpler to just make the save() method on the vmmDomain() object take a
flag such as 'background', and if set make it use a separate libvirt level
connection() object. Same end result, but closer to the design we'll need
when libvirt gets support for a VIR_DOMAIN_SAVE_ASYNC flag on the save()
method.
Regards,
Daniel.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the et-mgmt-tools
mailing list