[et-mgmt-tools] FYI: Changes to virtinst test suite

Cole Robinson crobinso at redhat.com
Mon Nov 24 22:24:45 UTC 2008

Hi all,

I've added some changes to the virtinst test suite that will affect
anyone writing patches. Two commands have been added to the setup.py script:

python setup.py check    : runs a pylint wrapper against the

python setup.py test_urls: runs a url fetching test suite

A patch shouldn't change the output of 'check'. If you hit something
which you think is a false positive or an unnecessary check, bring it up
on the list (though I've tried to remove all the blatantly useless
checks already). 'check' uses the pylint utility.

'test_urls' only needs to be run if changes are against the url fetching
code (virtinst/OSDistro and some virtinst/Distromanager). It takes a
while to run and requires a network connection, so I didn't include it
as part of the regular test suite ('setup.py test', which should also be
run with any changes).

All the above info was added to a HACKING file as well. I'll also be
adding a similar pylint script to virt-manager in the near future.


More information about the et-mgmt-tools mailing list