[et-mgmt-tools] [PATCH]: virt-manager: start network before vm creation

[Daniel P. Berrange]

On Mon, Sep 29, 2008 at 11:43:03AM -0400, Cole Robinson wrote:
> Guido Günther wrote:
> > Hi,
> > currently we don't check if a network is already running, when trying to
> > create a new machine in virt-manager. Attached patch starts the network
> > if it's not running instead of throwing an exception at the user,
> > adresses a Debian bug [1].
> > Cheers,
> >  -- Guido
> > 
> > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499867
> > 
> 
> Hmm, I'm not sure if I like this idea. Assumably the network is
> 'off' for a reason, so if the user doesn't know any better, I'd
> rather not just turn it on without their potentially knowing.
> 
> I think the problem here is that it isn't made clear in the
> drop down whether a virtual network is running or not. If we
> listed all the nets, but prevented the inactive ones from
> being selected (kind of like unbridged nics are presented)
> hopefully the user would get the point that they need to
> explicitly enable the network to use it. We could even allow
> selecting the inactive network and then prompt to start
> it.

Yep, as you say, there're two problems here. When creating the
VM we need to make it clear which networks are active, and which
are not - but still allow selection of an inactive network.

When starting a VM, we need to check fi the network is active. If
it is not, we should popup a confirmation dialog informing the
user, and /asking/ if we should automatically start the network
at this time.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|