[et-mgmt-tools] [patch] virt-convert - disk signature support - patch 1

[Cole Robinson]

Daniel P. Berrange wrote:
> On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
>> This adds the underlying support for disk signatures into virt-convert 
>> disk class for each disk. Additional changes to follow in completing 
>> implementation
> 
> There's not much point in doing md5 and sha1, both are more or
> less equivalent strength and compromised algorithms. Doing both
> is just wasting CPU resources. Pick either md5 or sha1 for sake
> of compatability with old python, and then sha256 for strength.
>

OVF seems to offer sha-1 hashes for packaged files, so let's
use that and sha256.
 
>> diff -r 2aba69a1a16c virtconv/diskcfg.py
>> --- a/virtconv/diskcfg.py	Mon Oct 06 12:21:17 2008 -0400
>> +++ b/virtconv/diskcfg.py	Wed Oct 08 12:19:19 2008 -0400
>> @@ -53,6 +53,11 @@
>>      "vdisk": DISK_FORMAT_VDISK,
>>  }
>>  
>> +checksum_types = {
>> +    CSUM_MD5 = 'md5'
>> +    CSUM_SHA1 = 'sha1'
>> +    CSUM_SHA256 = 'sha256'
>> +}

Stick a new line after this to preserve the previous spacing.

>>  def ensuredirs(path):
>>      """
>>      Make sure that all the containing directories of the given file
>> @@ -83,6 +88,7 @@
>>          self.bus = bus
>>          self.type = type
>>          self.clean = []
>> +        self.csum_dict = {}
>>  
>>      def cleanup(self):
>>          """
> 

Thanks,
Cole