[et-mgmt-tools] [patch] virt-image / ImageParser disk signature verification function

[Joey Boggs]

Cole,

That's fine I'll take a look after it's commited and write that down for 
future reference.

Cole Robinson wrote:
> Joey Boggs wrote:
>   
>> Better integrated into the Disk class and runs when a Disk object is
>> created
>>
>> diff -r db5d9aeca590 virtinst/ImageParser.py
>> --- a/virtinst/ImageParser.py	Fri Oct 10 10:32:50 2008 -0400
>> +++ b/virtinst/ImageParser.py	Thu Oct 16 09:41:22 2008 -0400
>> @@ -23,6 +23,8 @@
>>  import libxml2
>>  import CapabilitiesParser
>>  from virtinst import _virtinst as _
>> +import logging
>> +import urlgrabber.progress as progress
>>  
>>  class ParserException(Exception):
>>      def __init__(self, msg):
>> @@ -207,6 +209,7 @@
>>          self.csum = {}
>>          if not node is None:
>>              self.parseXML(node)
>> +        self.check_disk_signature()
>>   
>>     
>
> Do we really want this at init time? That doesn't
> provide the API user any way to prevent the csum
> checks from running. We should really make this
> optional from an API standpoint, but still make
> it the default in virt-image. Just dropping the
> above should solve that.
>
> That's really my only gripe, so I can fix it when
> I commit if it's okay with you.
>
> Thanks,
> Cole
>