[et-mgmt-tools] [PATCH] virtinst: fix --disk option parsing error message

Cole Robinson crobinso at redhat.com
Thu Oct 30 21:18:38 UTC 2008


Guido Günther wrote:
> Hi,
> the description is far longer than the patch:
> 
> ERROR    not all arguments converted during string formatting
> Traceback (most recent call last):
>   File "./virt-install", line 715, in <module>
>     main()
>   File "./virt-install", line 572, in main
>     options.sparse, options.nodisks, guest, hvm, conn)
>   File "./virt-install", line 243, in get_disks
>     is_file_path), disk, size)
>   File "./virt-install", line 243, in <lambda>
>     is_file_path), disk, size)
>   File "./virt-install", line 188, in get_disk
>     size, sparse) = parse_disk_option(guest, disk, size)
>   File "./virt-install", line 139, in parse_disk_option
>     fail(_("Unknown --disk option '%s'." % opt))
> TypeError: not all arguments converted during string formatting
> 
> Attached patch makes sure the tuple opt is converted to a string:
> 
> ERROR    Unknown --disk option '('device', 'disk')'.
> 
>  -- Guido
> 

Applied, thanks:

http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=fef7dd673020

- Cole




More information about the et-mgmt-tools mailing list