[et-mgmt-tools] [PATCH] virt-install: use --disk to specify size and sparse

Cole Robinson crobinso at redhat.com
Fri Sep 5 14:16:28 UTC 2008

The attached patch expands the options that can be
lumped onto virt-install's new --disk option to
specify size of new storage, and whether we want to
create it as sparse.

The format for these options is:

  --disk path=/some/new/file,size=5,sparse=true|false

This acts similar to the current options: if the file
doesn't exist, size is required, and we default to
sparse=True if it isn't specified.

This effectively deprecates --file, --file-size, and
--nonsparse, and in my opinion is much simpler. It also
helps overcome some problems we had with the original
options for cases of specifying multiple disks: there
was no way to specify one sparse disk and one nonsparse
disk, and generally specifying multiple disks was
unclear and a pain.

I also added a manpage section for the --disk option.

Any comments appreciated.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virtinst-disk-option-size-patch
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20080905/d4ea29e2/attachment.ksh>

More information about the et-mgmt-tools mailing list