[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH]: virt-manager: start network before vm creation



Guido Günther wrote:
> Hi,
> currently we don't check if a network is already running, when trying to
> create a new machine in virt-manager. Attached patch starts the network
> if it's not running instead of throwing an exception at the user,
> adresses a Debian bug [1].
> Cheers,
>  -- Guido
> 
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499867
> 

Hmm, I'm not sure if I like this idea. Assumably the network is
'off' for a reason, so if the user doesn't know any better, I'd
rather not just turn it on without their potentially knowing.

I think the problem here is that it isn't made clear in the
drop down whether a virtual network is running or not. If we
listed all the nets, but prevented the inactive ones from
being selected (kind of like unbridged nics are presented)
hopefully the user would get the point that they need to
explicitly enable the network to use it. We could even allow
selecting the inactive network and then prompt to start
it.

virt-manager 0.6.0 also allows setting the network's autostart
value from the gui, so if the network being inactive was
simply an oversight, the user can change it easily.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]