[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virtinst - virt-convert vmware output

On Mon, Sep 29, 2008 at 04:16:52PM -0400, Joey Boggs wrote:

> >>Not sure about this, all the other apps in virtinst use fail() now in 
> >>exceptions even virt-convert, or am I misunderstanding something?
> >
> >I just grepped and didn't see that. The only fail() usages are in
> >virtinst/cli.py. That's right and proper: library code like that in
> >virtconv/ (or most of virtinst/) should raise exceptions to allow the
> >caller to decide the correct behaviour (if I'm a daemon, I'd better keep
> >running; a GUI, I'd better bring up a dialog box, etc.).
> >  
> Cole updated it only a few days ago, here's what I'm seeing at least:
> grep -r "fail(" virt-convert
>        fail("Couldn't clean up output directory \"%s\": %s" %
>        fail("Couldn't import file \"%s\": %s" %
>        fail("Couldn't import file \"%s\": %s" % (options.input_file, e))
>            fail("Could not create directory %s: %s" %

Aren't these all in the file virt-convert? See above.

I can still write my daemon and use virtconv/ code without hitting a
fail. Your addition breaks that - is that clearer?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]