[et-mgmt-tools] [PATCH] virt-manager: show serial consoles as tabs in 'details' window

Cole Robinson crobinso at redhat.com
Tue Sep 30 16:04:13 UTC 2008

The attached patch combines the serial console window
with the VM details window. Opening the serial console
now appends a tab to the details view. In addition,
multiple serial consoles are now supported, not just
the primary/first defined console, though this still
only works for 'pty' devices.

The patch does three things: 

1) Remove all the previous plumbing needed to keep track
   of the separate console window
2) Fix the vmmSerialConsole class to extend gtk.HBox, so
   we can reuse most of the code in a notebook tab.
3) Add all the plumbing in details.py to deal with adding
   and removing tabs on the fly.

Screenshot of a couple tab examples:


Screenshot of selecting which serial console to open
(unsupported console types will have entries, they will
 just be disabled as shown):


Screenshot of terminal right click menu. Tabs can be
closed via this menu, or the 'View' menu shown in the
second screenshot.


Any comments appreciated.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: virt-manager-serial-console-tab.patch
Type: text/x-patch
Size: 19422 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20080930/7b6dae16/attachment.bin>

More information about the et-mgmt-tools mailing list