[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virt-manager: remove disambiguity in "free space" dialog



Guido Günther wrote:
> On Mon, Feb 09, 2009 at 08:21:29AM +0000, Mark McLoughlin wrote:
>> Hi Guido,
>>
>> On Sat, 2009-02-07 at 21:34 +0100, Guido Günther wrote:
>>> -                res = self.err.yes_no(_("Not Enough Free Space"), ret[1])
>>> +                res = self.err.yes_no(_("Not Enough Free Space"), _("%s. Continue anyway?") % ret[1])
>>>                  if not res:
>>>                      return False
>> See the GNOME HIG:
>>
>>   http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-button-order
>>
>> I think what you want here is to change the buttons to Cancel/Continue -
>> i.e. a Cancel button and an affirmative verb button.
> I've changed this to "Ok/Cancel" in the attached patch. A simple Ok
> looks more obvious to me in this case since I'd be unsure to continue
> with what (it's not creating wizard in the case of add_hardware) and the
> only thing the user has to do is to acknowledge.
>  -- Guido
> 

Thanks, applied now:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/60940c2af2db

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]