[et-mgmt-tools] [PATCH] virt-manager: List VM 'hostdev' devices

Cole Robinson crobinso at redhat.com
Tue Jan 20 22:41:48 UTC 2009


The attached patch adds support for listing, viewing details of, and
removing VM 'hostdev' devices. libvirt currently supports usb and pci
host devices, so I tried to tackle all the variants for each. Some
example screeenshots:

http://fedorapeople.org/~crobinso/virt-manager/vmm-show-hostdev1.png
http://fedorapeople.org/~crobinso/virt-manager/vmm-show-hostdev2.png

A couple particulars:

- There is no icon for a 'hostdev' in the VM's hardware list. We've been
stretching use of gtk stock icons pretty thin, and there really isn't
anything available that makes sense. This will be addressed when we
integrate custom icons (next release).

- The parameter differences between PCI, USB by vendor/product, and USB
by bus/device number are pretty large. Rather than have 10 different GUI
fields, populating only what is appropriate and hiding the others, I
just generate a single line listing for the device details section (ex.
"Bus: 001, Device: 002". This is shown in the screenshots. It's a bit
uglier this way, but much simpler, and conveys all the same information.

Any comments appreciated.

Thanks,
Cole
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmm-list-hostdevs.patch
Type: text/x-diff
Size: 21129 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20090120/fcb664ac/attachment.bin>


More information about the et-mgmt-tools mailing list