[et-mgmt-tools] don't show ui dialogs in construction time

Vitaly Mayatskikh vmayatsk at redhat.com
Fri Jan 30 14:31:19 UTC 2009


Hi!

There are calls to hide_all() method after construction of vmm-manager
and vmm-details dialogs to prevent possible flickering during
appending more elements to these dialogs. However, it is possible to
declare visibility property in xml files and to prevent libglade to
show dialogs automatically.

diff -r 375f441f26e1 src/virtManager/details.py
--- a/src/virtManager/details.py        Mon Jan 26 13:07:58 2009 -0500
+++ b/src/virtManager/details.py        Fri Jan 30 15:25:40 2009 +0100
@@ -107,7 +107,6 @@
         self.vm = vm
 
         topwin = self.window.get_widget("vmm-details")
-        topwin.hide_all()
         self.err = vmmErrorDialog(topwin,
                                   0, gtk.MESSAGE_ERROR, gtk.BUTTONS_CLOSE,
                                   _("Unexpected Error"),
diff -r 375f441f26e1 src/virtManager/manager.py
--- a/src/virtManager/manager.py        Mon Jan 26 13:07:58 2009 -0500
+++ b/src/virtManager/manager.py        Fri Jan 30 15:25:40 2009 +0100
@@ -112,7 +112,6 @@
     def __init__(self, config, engine):
         self.__gobject_init__()
         self.window = gtk.glade.XML(config.get_glade_dir() + "/vmm-manager.glade", "vmm-manager", domain="virt-manager")
-        self.window.get_widget("vmm-manager").hide_all()
         self.err = vmmErrorDialog(self.window.get_widget("vmm-manager"),
                                   0, gtk.MESSAGE_ERROR, gtk.BUTTONS_CLOSE,
                                   _("Unexpected Error"),
diff -r 375f441f26e1 src/vmm-details.glade
--- a/src/vmm-details.glade     Mon Jan 26 13:07:58 2009 -0500
+++ b/src/vmm-details.glade     Fri Jan 30 15:25:40 2009 +0100
@@ -3,7 +3,7 @@
 <!--*- mode: xml -*-->
 <glade-interface>
   <widget class="GtkWindow" id="vmm-details">
-    <property name="visible">True</property>
+    <property name="visible">False</property>
     <property name="title" translatable="yes">Virtual Machine</property>
     <property name="default_width">700</property>
     <property name="default_height">540</property>
diff -r 375f441f26e1 src/vmm-manager.glade
--- a/src/vmm-manager.glade     Mon Jan 26 13:07:58 2009 -0500
+++ b/src/vmm-manager.glade     Fri Jan 30 15:25:40 2009 +0100
@@ -3,7 +3,7 @@
 <!--*- mode: xml -*-->
 <glade-interface>
   <widget class="GtkWindow" id="vmm-manager">
-    <property name="visible">True</property>
+    <property name="visible">False</property>
     <property name="title" translatable="yes">Virtual Machine Manager</property>
     <property name="default_width">700</property>
     <property name="default_height">500</property>
--
wbr, Vitaly




More information about the et-mgmt-tools mailing list