[et-mgmt-tools] virtinst: acpi/apic == FALSE for Windows XP

[Laurent Léonard]

Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :
> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
> > Pasi Kärkkäinen wrote:
> > > On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
> > >> On 07/05/2009 08:27 AM, Guido Günther wrote:
> > >>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> > >>>> Hi,
> > >>>> virtinst has:
> > >>>>
> > >>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
> > >>>>                   "acpi": False, "apic": False },
> > >>>>
> > >>>> I couldn't find any reason for this in the hg logs and
> > >>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> > >>>
> > >>> The correct URL is:
> > >>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> > >>> Cheers,
> > >>>  -- Guido
> > >>
> > >> AFAIK this was done because windows installs on xen used to choke if
> > >> ACPI was enabled. There is an old wiki page corroborating that here,
> > >> no idea if it is still relevant, or if there were other issues at
> > >> play:
> > >>
> > >> http://wiki.xensource.com/xenwiki/XenWindowsACPI
> > >
> > > I think that's obsolete and nowadays ACPI (and APIC) should be enabled
> > > for Xen Windows guests.
> > >
> > > Please correct me if I'm wrong.
> >
> > You are probably correct, although testing (especially on things like
> > RHEL-5 Xen) is in order before making the change for Xen as well.
>
> I actually asked about this on xen-devel, and Keir Fraser replied that ACPI
> with Windows has been working properly at least since Xen 3.1.0 days.

I also installed Windows 2000 Server virtual machines with ACPI enabled on 
Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.

So the attached patch should be applied to virtinst to:
- Enable ACPI and APIC for Windows XP
- Enable ACPI and APIC for Windows 2000
- Merge Windows XP x86 and x86_64 variants because there is no more reason to 
have different variants for the same OS

-- 
Laurent Léonard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: windows_acpi.diff
Type: text/x-diff
Size: 824 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20090708/36d6f613/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20090708/36d6f613/attachment.sig>