[PATCH] ext3: Fix sparse -Wbitwise warnings.
Stephen C. Tweedie
sct at redhat.com
Tue Feb 15 23:25:53 UTC 2005
On Tue, 2005-02-15 at 23:29, Mitchell Blank Jr wrote:
> Of course that's less efficient though since "mask" is probably constant..
> so now the endian conversion changed from compile-time to run-time.
> Would something like
> ( ( EXT3_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask) ) != 0)
> be enough to satisfy sparse?
Yes, but it breaks other places: there are a few places where callers
actually want the real return value from the "&", so that (for example)
they can tell the user which feature failed the compatibility test.
More information about the Ext3-users