[PATCH - RFC] unify config parsing

Michael_E_Brown at Dell.com Michael_E_Brown at Dell.com
Tue May 16 19:07:28 UTC 2006


The recent changes to add default.cfg processing bumped the number of
lines in main(). The following patch unifies all config file parsing
into one small loop, removing about a dozen redundant lines of code. It
also removes an unnecessary variable, config_path and uses
options.configdir directly.

This is an RFC because it changes mock behaviour in the following way,
which requres discussion: The "-r" option is no longer required. You
will not get an error message for a missing "-r" option. 

I think this might be useful for the case where somebody sets up their
'default.cfg' to be a full config.

Comments?
--
Michael

 <<mock-cfgunify.patch>> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20060516/89e23591/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mock-cfgunify.patch
Type: application/octet-stream
Size: 2045 bytes
Desc: mock-cfgunify.patch
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20060516/89e23591/attachment.obj>


More information about the Fedora-buildsys-list mailing list