PATCH: plague-0.5.0: PackageJob.py: NameError _and_ YumBaseError (unable to kill its job)

[Joe Todaro]

---- PROBLEM # 1 ----  Depsolve step keeps crashing due to a typo in the 
script: 

364 (fuse-sshfs): Starting depsolve for arches: ['x86_64', 'i386'].
Exception in thread PackageJob: 364/fuse-sshfs:
[...snip...]
>   File "/usr/share/plague/server/PackageJob.py", line 513, in 
> _arch_deps_solved 
>     base.log = logger.Logger(threshold=threshold, 
file_object=sys.stdout) 
> NameError: global name 'logger' is not defined 


---- PROBLEM # 2 ---- Unable to kill any job that fails due to a missing 
package/s in the yum repos:

>   File "/usr/share/plague/server/PackageJob.py", line 548, in 
_arch_deps_solved 
>    pkg = base.returnPackageByDep(dep) 
>   File "__init__.py", line 1342, in returnPackageByDep 
> YumBaseError: No Package found for fuse-devel 


---- PATCH ---- 

Here's the patch that resolved the above 2 problems for us: 
 


----- REQUEST ----

Can someone please review it... especially the fix to PROBLEM # 2, that 
could potentially be masking a bigger problem.. 

Here's the code for your convenience (...these are the updates we made to 
the _latest_ version of PackageJob.py):

$ cd /usr/share/plague/server
$ diff PackageJob.py PackageJob.py.working
513c513
<                 base.log = logger.Logger(threshold=threshold, 
file_object=sys.stdout)
---
>                 base.log = Logger(threshold=threshold, 
file_object=sys.stdout)
698c698
<         if self._curstage == 'waiting':
---
>         if self._curstage in ['waiting', 'depsolve']:


Thanks,
  Joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20061105/0a3cf68d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PackageJob.py-NameError+YumBaseError-fix.patch
Type: application/octet-stream
Size: 957 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20061105/0a3cf68d/attachment.obj>