RFC - Patch - koji SCM generalization

rob myers rob.myers at gtri.gatech.edu
Tue Nov 6 21:22:55 UTC 2007


On Tue, 2007-11-06 at 15:33 -0500, Mike Bonnet wrote:
> On Tue, 2007-11-06 at 11:16 -0500, rob myers wrote:
> > 
> > i did some testing with my svn+ssh repository and found the patch below
> > necessary- it creates ../common only if it does not already exist.
> > 
> > diff --git a/builder/kojid b/builder/kojid
> > index b436a19..5c5d665 100755
> > --- a/builder/kojid
> > +++ b/builder/kojid
> > @@ -2506,7 +2507,8 @@ class SCM(object):
> >                      (self.scmtype, ' '.join(update_checkout_cmd),
> > os.path.basename(logfile))
> >  
> >          # Required by Dist CVS layout
> > -        os.symlink('%s/common' % scmdir, '%s/../common' % sourcedir)
> > +        if not os.path.exists('%s/../common' % sourcedir):
> > +            os.symlink('%s/common' % scmdir, '%s/../common' %
> > sourcedir)
> >  
> >  def get_options():
> >      """process options from command line and config file"""
> 
> The patch looks good, I've applied it.  Just out of curiousity, where
> did the common/ directory come from, an svn:external?

nope nothing fancy; it is just another dir sitting at the same level as
all the packages.

thanks again.

rob.




More information about the Fedora-buildsys-list mailing list