[PATCHES] Makefile.common speedups

Toshio Kuratomi a.badger at gmail.com
Wed Jul 30 17:26:16 UTC 2008


Adam Jackson wrote:
> Attached are two (orthogonal) patches to make evaluation of
> Makefile.common a bit faster.
> 
> The first one is possibly contentious.  Currently, early-branching works
> by checking for the existence of the other branch, by using 'cvs rlog'.
> That kinda sucks, because it means you can't do 'make local' while
> disconnected, and even when connected it's not fast.  The patch changes
> it to look for the package's name in a new file,
> common/early-branched-packages.  By keeping that file together with
> Makefile.common we get pretty much the behaviour we're used to: when
> build targets change, you have to update common/.  Note that if we apply
> this patch we will also need to create that (empty) file.
> 
> This would change the cvsadmin procedure for early branching, but
> hopefully not by a burdensome amount.
> 
I'm against this one as it moves a kludge from Makefile.common into the 
scripts that handle branching.  Can we achieve the same thing by keeping 
the information in the devel branch?  For instance, each of the other 
branches has a branch file with the branch name inside.  If devel did 
the same, could we alleviate this problem?

(Branch scripts might still need to be updated to write/verify the 
branch file in the devel directory but that would be more generic than 
writing into an early branch file)

-Toshio


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20080730/09405e4f/attachment.sig>


More information about the Fedora-buildsys-list mailing list