[PATCH] new pungi command line options

Jeremy Katz katzj at redhat.com
Thu Oct 16 19:30:12 UTC 2008


On Thu, 2008-10-16 at 12:15 -0700, Jesse Keating wrote:
> On Thu, 2008-10-16 at 14:08 -0500, Paul B Schroeder wrote:
> > In my kickstart config, the %include files are all generated in %pre
> > and don't exist at compose time, thus "--ignore-missing-includes".
> > And I have no repo lines defined in my ks.cfg either, so the --repo-*
> > options allow you to specify or add repo info from the command line.
> > 
> >  --repo-baseurl=REPO BASEURL
> >                        repository name and base URL to use
> >  --repo-mirrorlist=REPO MIRRORLIST
> >                        repository name and mirrorlist URL to use
> >  --ignore-missing-includes
> >                        ignore missing %include files in the kickstart
> > config
> 
> Rather than throw more command line options at the problems, I wonder if
> it would make more sense to make the kickstart parsing gracefully handle
> and warn about missing includes.  

Yeah, I would think this should just work.  I know it's something that's
been used to good effect within anaconda in the past.  

> I also really don't like doing repo
> declaration via the command line arguments, but I'll think on this one a
> bit more.

I definitely don't like this -- the idea of using a kickstart config for
pungi, livecd-creator, etc is that the config file can be enough to
reliably recreate a set of images.  Passing the repos on the command
line makes this entirely not the case.

Jeremy




More information about the Fedora-buildsys-list mailing list