[Fwd: [PATCH] Use hashlib if available instead of md5]

Jeremy Katz katzj at redhat.com
Mon Feb 2 22:28:12 UTC 2009


On Monday, February 02 2009, Jesse Keating said:
> This patch converts all calls of md5 function to use hashlib if present.
> The old md5 function is deprecated in Python 2.6, and this silences the
> warning messages (along with providing a slight performance improvement).

Rather than scattering lazy imports in a try except all over the koji
code, I wonder if it's worth adding a wrapper in koji.util and only
doing the try/except once at the module level there.  Probably not
speed-critical code, but it would also keep things a little more
readable

Jeremy




More information about the Fedora-buildsys-list mailing list