[Fwd: [PATCH] Use hashlib if available instead of md5]
seth vidal
skvidal at fedoraproject.org
Mon Feb 2 23:08:04 UTC 2009
On Mon, 2009-02-02 at 17:28 -0500, Jeremy Katz wrote:
> On Monday, February 02 2009, Jesse Keating said:
> > This patch converts all calls of md5 function to use hashlib if present.
> > The old md5 function is deprecated in Python 2.6, and this silences the
> > warning messages (along with providing a slight performance improvement).
>
> Rather than scattering lazy imports in a try except all over the koji
> code, I wonder if it's worth adding a wrapper in koji.util and only
> doing the try/except once at the module level there. Probably not
> speed-critical code, but it would also keep things a little more
> readable
>
or just have koji import Checksums from yum.misc.
since yum does this already.
-sv
More information about the Fedora-buildsys-list
mailing list