rpms/kernel/FC-4 linux-2.6-i2c-it87-reboot.patch, NONE, 1.1 kernel-2.6.spec, 1.1576, 1.1577

[fedora-cvs-commits at redhat.com]

Author: davej

Update of /cvs/dist/rpms/kernel/FC-4
In directory cvs.devel.redhat.com:/tmp/cvs-serv1297

Modified Files:
	kernel-2.6.spec 
Added Files:
	linux-2.6-i2c-it87-reboot.patch 
Log Message:
* Tue Jan 24 2006 Dave Jones <davej at redhat.com> [2.6.15-1.1825_FC4]
- Fix it87 probing problem which caused reboots on some hardware.


linux-2.6-i2c-it87-reboot.patch:
 Documentation/feature-removal-schedule.txt |    9 +++++++++
 Documentation/hwmon/it87                   |    2 +-
 drivers/hwmon/it87.c                       |    8 ++++++--
 3 files changed, 16 insertions(+), 3 deletions(-)

--- NEW FILE linux-2.6-i2c-it87-reboot.patch ---
Only scan I2C address 0x2d. This is the default address and no IT87xxF
chip was ever seen on I2C at a different address. These chips are
better accessed through their ISA interface anyway.

This fixes bug #5889, although it doesn't address the whole class
of problems. We'd need the ability to blacklist arbitrary I2C addresses
on systems known to contain I2C devices which behave badly when probed.

Plan the I2C interface for removal as well. If nobody complains within
a year, it will confirm my impression that the I2C interface isn't
actually needed by anyone.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
 Documentation/feature-removal-schedule.txt |    9 +++++++++
 Documentation/hwmon/it87                   |    2 +-
 drivers/hwmon/it87.c                       |    8 ++++++--
 3 files changed, 16 insertions(+), 3 deletions(-)

--- linux-2.6.15-git.orig/Documentation/hwmon/it87	2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.15-git/Documentation/hwmon/it87	2006-01-15 13:28:34.000000000 +0100
@@ -9,7 +9,7 @@
                http://www.ite.com.tw/
   * IT8712F
     Prefix: 'it8712'
-    Addresses scanned: I2C 0x28 - 0x2f
+    Addresses scanned: I2C 0x2d
                        from Super I/O config space (8 I/O ports)
     Datasheet: Publicly available at the ITE website
                http://www.ite.com.tw/
--- linux-2.6.15-git.orig/drivers/hwmon/it87.c	2006-01-15 13:04:33.000000000 +0100
+++ linux-2.6.15-git/drivers/hwmon/it87.c	2006-01-15 15:41:25.000000000 +0100
@@ -46,8 +46,7 @@
 
 
 /* Addresses to scan */
-static unsigned short normal_i2c[] = { 0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d,
-					0x2e, 0x2f, I2C_CLIENT_END };
+static unsigned short normal_i2c[] = { 0x2d, I2C_CLIENT_END };
 static unsigned short isa_address;
 
 /* Insmod parameters */
@@ -831,6 +830,11 @@
 	if ((err = i2c_attach_client(new_client)))
 		goto ERROR2;
 
+	if (!is_isa)
+		dev_info(&new_client->dev, "The I2C interface to IT87xxF "
+			 "hardware monitoring chips is deprecated. Please "
+			 "report if you still rely on it.\n");
+
 	/* Check PWM configuration */
 	enable_pwm_interface = it87_check_pwm(new_client);
 
--- linux-2.6.15-git.orig/Documentation/feature-removal-schedule.txt	2006-01-15 10:49:14.000000000 +0100
+++ linux-2.6.15-git/Documentation/feature-removal-schedule.txt	2006-01-15 15:22:22.000000000 +0100
@@ -148,3 +148,12 @@
 	brother on Alchemy SOCs.  The loss of features is not considered an
 	issue.
 Who:	Ralf Baechle <ralf at linux-mips.org>
+
+---------------------------
+
+What:	I2C interface of the it87 driver
+When:	January 2007
+Why:	The ISA interface is faster and should be always available. The I2C
+	probing is also known to cause trouble in at least one case (see
+	bug #5889.)
+Who:	Jean Delvare <khali at linux-fr.org>


Index: kernel-2.6.spec
===================================================================
RCS file: /cvs/dist/rpms/kernel/FC-4/kernel-2.6.spec,v
retrieving revision 1.1576
retrieving revision 1.1577
diff -u -r1.1576 -r1.1577
--- kernel-2.6.spec	17 Jan 2006 05:27:47 -0000	1.1576
+++ kernel-2.6.spec	24 Jan 2006 19:57:49 -0000	1.1577
@@ -352,6 +352,7 @@
 Patch1830: linux-2.6-smsc-ircc2-pnp.patch
 Patch1860: linux-2.6-posix-timers-sched_time-accumulation.patch
 Patch1870: linux-2.6-kill-blk_attempt_merge.patch
+Patch1880: linux-2.6-i2c-it87-reboot.patch
 
 # Warn about usage of various obsolete functionality that may go away.
 Patch1900: linux-2.6-obsolete-idescsi-warning.patch
@@ -791,6 +792,8 @@
 %patch1860 -p1
 # kill blk_attempt_merge
 %patch1870 -p1
+# Some it87 probing causes reboots on some systems.
+%patch1880 -p1
 
 # Warn about obsolete functionality usage.
 %patch1900 -p1
@@ -1267,7 +1270,10 @@
 %endif
 
 %changelog
-* Sun Jan 15 2006 Dave Jones <davej at redhat.com> [2.6.15-1.1825_FC4]
+* Tue Jan 24 2006 Dave Jones <davej at redhat.com> [2.6.15-1.1825_FC4]
+- Fix it87 probing problem which caused reboots on some hardware.
+
+* Sun Jan 15 2006 Dave Jones <davej at redhat.com>
 - 2.6.15.1
 - Disable slab debug.