rpms/pygobject2/FC-6 pygobject-2.12.3-memory-leak.patch, NONE, 1.1 pygobject2.spec, 1.21, 1.22 pygobject-2.11.4-docs.patch, 1.1, NONE

fedora-cvs-commits at redhat.com fedora-cvs-commits at redhat.com
Fri Apr 20 01:38:49 UTC 2007


Author: mbarnes

Update of /cvs/dist/rpms/pygobject2/FC-6
In directory cvs.devel.redhat.com:/tmp/cvs-serv2654

Modified Files:
	pygobject2.spec 
Added Files:
	pygobject-2.12.3-memory-leak.patch 
Removed Files:
	pygobject-2.11.4-docs.patch 
Log Message:

* Thu Apr 19 2007 Matthew Barnes <mbarnes at redhat.com> - 2.12.3-2.fc6
- Add patch for RH bug #237179 (memory leak).


pygobject-2.12.3-memory-leak.patch:
 pygflags.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

--- NEW FILE pygobject-2.12.3-memory-leak.patch ---
--- pygobject-2.12.3/gobject/pygflags.c.memory-leak	2007-04-19 21:29:49.000000000 -0400
+++ pygobject-2.12.3/gobject/pygflags.c	2007-04-19 21:30:33.000000000 -0400
@@ -176,7 +176,9 @@
     retval = PyDict_GetItem(values, pyint);
     Py_DECREF(pyint);
 
-    if (!retval) {
+    if (retval) {
+	Py_INCREF(retval);
+    } else {
 	PyErr_Clear();
 
 	retval = ((PyTypeObject *)pyclass)->tp_alloc((PyTypeObject *)pyclass, 0);
@@ -186,7 +188,6 @@
 	((PyGFlags*)retval)->gtype = gtype;
     } 
 
-    Py_INCREF(retval);
     return retval;
 }
 


Index: pygobject2.spec
===================================================================
RCS file: /cvs/dist/rpms/pygobject2/FC-6/pygobject2.spec,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- pygobject2.spec	18 Nov 2006 19:23:54 -0000	1.21
+++ pygobject2.spec	20 Apr 2007 01:38:47 -0000	1.22
@@ -4,7 +4,7 @@
 
 Name: pygobject2
 Version: 2.12.3
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: LGPL
 Group: Development/Languages
 Summary: Python bindings for GObject
@@ -12,6 +12,11 @@
 BuildRoot: %{_tmppath}/%{name}-%{version}-root
 Source: pygobject-%{version}.tar.bz2
 
+### Patches ###
+
+# RH bug #237179 / GNOME bug #428726
+Patch1: pygobject-2.12.3-memory-leak.patch
+
 ### Dependencies ###
 
 Requires: glib2 >= 2.8
@@ -49,6 +54,7 @@
 
 %prep
 %setup -q -n pygobject-%{version}
+%patch1 -p1 -b .memory-leak
 
 %build
 %configure --enable-thread --disable-docs
@@ -91,6 +97,9 @@
 %{_datadir}/pygobject/xsl
 
 %changelog
+* Thu Apr 19 2007 Matthew Barnes <mbarnes at redhat.com> - 2.12.3-2.fc6
+- Add patch for RH bug #237179 (memory leak).
+
 * Sat Nov 18 2006 Matthew Barnes <mbarnes at redhat.com> - 2.12.3-1.fc6
 - Update to 2.12.3
 


--- pygobject-2.11.4-docs.patch DELETED ---




More information about the fedora-cvs-commits mailing list