[fedora-java] Eclipse plugin building script
Andrew Overholt
overholt at redhat.com
Thu Apr 3 13:16:26 UTC 2008
Hi Mat,
On Thu, 2008-04-03 at 01:14 +0100, Mat Booth wrote:
> On Tue, Apr 1, 2008 at 3:29 AM, Andrew Overholt <overholt at redhat.com> wrote:
> >
> > Yes. I didn't want to mess with copy-platform since I wanted to get
> > this script into a build of the SDK. If you -- or anyone else -- has a
> > few minutes to make this modification, I'd appreciate any patches.
> >
> > Andrew
> >
>
> Sure thing, see attached. This patch changes
> "eclipse-copy-platform.sh" and "eclipse.spec" from the Rawhide eclipse
> package. I hope that's ok.
Awesome, thanks!
My only nit is this:
-sed -e's/^\(.*\)$/\1 \1/' -e's,^,ln -s $eclipse/,' >> copy-platform
+sed -e's/^\(.*\)$/\1/' -e's,^\(.*\),[ ! -e \1 ] \&\& ln -s $eclipse/\1
\1,' >> copy-platform
I don't think you need the first sed command, do you? Would removing it
still accomplish the same thing? Like this:
sed -e's,^\(.*\),[ ! -e \1 ] \&\& ln -s $eclipse/\1 \1,'
Did you want to just commit this? If you request commit on the eclipse
module in the account system, I'll grant it.
Thanks again,
Andrew
More information about the fedora-devel-java-list
mailing list