Please verify: GDM miscounts current sessions

Warren Togami wtogami at redhat.com
Mon Feb 2 03:22:13 UTC 2004


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=110315
GDM miscounts current sessions

* Sun Feb 01 2004 Warren Togami <wtogami at redhat.com> 1:2.4.4.5-8
- patch30 xdmcp_session counter fix from gdm-2.5.90.0 #110315
- automake14 really needed, not automake
- BR libcroco-devel, libcroco-devel, libattr-devel, gettext
- conditionally BR libselinux-devel
- explicit epoch in all deps

gdm-2.x from FC1 and FC2 rawhide fail to properly count the number of 
concurrent XDMCP sessions.  Rather than a maximum simultaneous sessions 
counter, MaxSessions parameter became a maximum number of sessions 
forever counter.

The original code LOOKS correct, but gdm-2.5.90.0 hints to a race 
condition that could be causing this behavior.  I copied the code from 
gdm-2.5.90.0 into rawhide's gdm and it seems to work.  The spec patch 
also contains explicit BuildRequires fixes and versioned-dep-epochs.

Please verify that the patch solves the problem without introducing any 
regressions.  A redone package will need to go into FC1 updates/testing 
soon too, especially for the K12LTSP folks.

If these changes look good, I ask that Havoc check them into rawhide 
ASAP.  It should not be too late to make FC2 test1 (I hope especially 
since changeloop is still broken.)

Warren Togami
wtogami at redhat.com





More information about the fedora-devel-list mailing list