[RFE, Patch, Multi-lib] 32bit support /usr/bin/firefox

[Gilboa Davara]

On Sat, 2006-11-11 at 11:19 -0500, Warren Togami wrote:
> Gilboa Davara wrote:
> > Hello all,
> > 
> > The attached patch (which should cover all 64bit arches) enable you to
> > start the 32bit version of firefox (if it's installed) by starting
> > firefox with the "--32" command line option.
> > 
> > Before I submit this to bugzilla, I have two questions:
> > 
> > - Do we rather have a single firefox script that executes both 32bit and
> > 64bit or do we want to break the it to dedicated firefox[64] and
> > firefox32 scripts.
> > - Where should I submit this patch? Mozilla or redhat?
> > 
> > - Gilboa
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214100
> I wrote an alternative implementation in this bug.  I don't fully agree 
> with the rejection of this, but I do agree that the best long-term 
> solution is to fix nspluginwrapper to offload *ALL* plugins to a 
> separate process.  A separate process also allows greater security 
> control with selinux.
> 
> Logic of my Implementation:
> 
> * If only the /usr/lib	 browser is installed, run it.
> * If only the /usr/lib64 browser is installed, run it.
> * If both are installed, run /usr/lib64 unless it is overridden in
> /etc/sysconfig/firefox-arch.
> * Allow editing /etc/sysconfig/firefox-arch as the official means for 
> the system administrator to override their arch selection.
> 
> %config(noreplace) %{_sysconfdir}/sysconfig/firefox-arch
> This is necessary in the %files section of firefox.spec.
> 
> Benefits of this approach:
> 1) This DOES NOT CHANGE the behavior from its current default, which 
> works with browsers shipped on x86_64.
> 2) This defines an explicit way for the system administrator to override 
> their arch selection in a way that wont break with future package 
> updates.  This effectively enables CHOICE.
> 

This a nice solution - though I rather have a simple method of
overriding the selection without editing a configuration file and/or
making it system wide.
IMHO, adding a command line parameters seems like the obvious choice as
it gives the user additional means of controlling which version is
executed.

I can combine your patch with mine - read, use the default
in /etc/sysconfig/firefox-arch unless the user specifically requested
something else. 
Does it sound reasonable to you?

- Gilboa