rpms/samba/devel samba.spec,1.124,1.125

[Tom "spot" Callaway]

On Fri, 2007-06-29 at 23:12 -0400, Jeremy Katz wrote:
> On Fri, 2007-06-29 at 16:52 -0400, Adam Jackson wrote:
> > On Fri, 2007-06-29 at 16:04 -0400, Simo Sorce wrote:
> > > On Fri, 2007-06-29 at 21:50 +0200, Patrice Dumas wrote:
> > > > On Fri, Jun 29, 2007 at 03:42:22PM -0400, Simo Sorce wrote:
> > > > > +    eval testparm -s 2>/dev/null |grep "lock dir" >/dev/null
> > > > > +    if [ $? = 0 ]; then 
> > > > > +	echo "Warning: lock dir explicitly set. Not moving tdb files to new default location"
> > > > 
> > > > Unless I am wrong, echoing anything during updates is not right...
> > > 
> > > I've seen warning for when files are dropped in as .rpmnew or saved
> > > as .rpmsave
> > > This is a very similar case, so I think it should be ok, but if not I'd
> > > like to know (and know why rpmnew/rpmsave are instead ok)
> > 
> > That warning is issued from RPM itself.  Which means there's probably a
> > hook to do something with that information from a GUI tool.
> 
> Actually, there's not.  So this case is no better or worse

Strictly speaking, we've never said that you can't echo things.

It's pointless, really, but we've never forbidden it. Now, interactive
prompting? That's forbidden.

~spot