Yum-presto (deltarpms) ready for testing.

[seth vidal]

On Mon, 2007-03-26 at 21:51 +0300, Jonathan Dieter wrote:
> On Mon, 2007-03-26 at 19:59 +0200, Leszek Matok wrote:
> > Dnia 26-03-2007, pon o godzinie 20:43 +0300, Jonathan Dieter napisał(a):
> > > The second time your ran it,
> > > it realized there was a problem and downloaded the full rpm.
> > Can't it restart the process or simply download the full rpm at the same
> > time it sees an unusable drpm, then proceed with the update as planned?
> > 
> > > I would really love to know if you've done anything with lucidlife,
> > > changed any files before upgrading to the latest version?  It would help
> > > me work out why we hit this error in the first place.
> > No, I haven't even run it for half a year or so. Also, rpm -V doesn't
> > report anything.
> > 
> > Could it be that the drpm was being uploaded/generated that very moment
> > I was trying to download it? Of course that would mean the metadata was
> > uploaded/generated earlier than actual drpms, but who knows?
> > 
> > Lam
> Okay, I've finally tracked down where it all went wrong.  When Presto
> wasn't running applydeltarpm with on-disk MD5 checking.  It was only
> checking file sizes.  So if a file got one byte changed, it wouldn't
> catch that the patch wouldn't apply any more.  I've fixed this so it
> does a full (slow) MD5 check when it finds an applicable DRPM in 0.2.9.
> 
> Please, please let me know if anyone hits the "Error rebuilding at least
> one deltarpm." error.  It shouldn't happen anymore, but I'd like to know
> if it does.
> 

1. why are you using md5sum and not sha1sums?
2. what function are you using to do this check? Yum has a checksum
function you might be able to just use.

-sv