Two Problems

[Tom "spot" Callaway]

On Mon, 2007-11-26 at 13:10 -0800, Eric Work wrote:

> 2. The other problem is that gtkdatabox is unable to build on x86_64 do 
> to some problem with -fPIC even though it's being used when the source 
> files are compile.  I was able to compile the source on my 64-bit Ubuntu 
> machine with no problems.  Maybe a problem with autotools?  The koji 
> taskID is: 259807.

No, its a problem with the gtkdatabox source. Ubuntu might not have
caught it because G_GNUC_INTERNAL isn't defined in their toolchain (just
guessing). The gtk_databox_marshal_VOID__POINTER_POINTER has the
G_GNUC_INTERNAL attribute on it in the .h file, but not in the .c file,
thus the confusion at link time.

I've attached two patches, one to fix the x86_64 compile error, and the
other to make gtkdatabox use the Fedora optflags. And as a bonus, I've
attached a new spec file which not only applies these patches, it also
fixes the license tag to be in compliance with the Fedora licensing
policy.

But Wait! There's more!

...

Actually, no. That's it.

hth,

~spot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtkdatabox-0.8.0.1-compilefix.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-devel-list/attachments/20071126/f5f53f70/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtkdatabox-0.8.0.1-userpmoptflags.patch
Type: text/x-patch
Size: 1768 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-devel-list/attachments/20071126/f5f53f70/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtkdatabox.spec
Type: text/x-rpm-spec
Size: 2431 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-devel-list/attachments/20071126/f5f53f70/attachment-0002.bin>