compiler bug turning up in cmake package?

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Rex Dieter wrote:
> So the simple(?) fix involves something like:
> http://rdieter.fedorapeople.org/cmake-2.6.1-parens.patch
> ??

No, quite wrong.  A hand-edited patch:

diff -up cmake-2.6.1/Source/cmELF.cxx.parens cmake-2.6.1/Source/cmELF.cxx
- --- cmake-2.6.1/Source/cmELF.cxx.parens	2008-08-01 10:34:52.000000000
-0500
+++ cmake-2.6.1/Source/cmELF.cxx	2008-08-26 13:21:55.000000000 -0500
@@ -884,8 +884,8 @@ cmELF::StringEntry const* cmELF::GetSONa
  cmELF::StringEntry const* cmELF::GetRPath()
 {
   if(this->Valid() &&
- -     this->Internal->GetFileType() == cmELF::FileTypeExecutable ||
- -     this->Internal->GetFileType() == cmELF::FileTypeSharedLibrary)
+     (this->Internal->GetFileType() == cmELF::FileTypeExecutable ||
+      this->Internal->GetFileType() == cmELF::FileTypeSharedLibrary))
     {
     return this->Internal->GetRPath();
     }
@@ -898,9 +898,9 @@ cmELF::StringEntry const* cmELF::GetRPat
  cmELF::StringEntry const* cmELF::GetRunPath()
 {
   if(this->Valid() &&
- -     this->Internal->GetFileType() == cmELF::FileTypeExecutable ||
- -     this->Internal->GetFileType() == cmELF::FileTypeSharedLibrary)
+     (this->Internal->GetFileType() == cmELF::FileTypeExecutable ||
+      this->Internal->GetFileType() == cmELF::FileTypeSharedLibrary))
     {
     return this->Internal->GetRunPath();
     }


- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAki0U70ACgkQ2ijCOnn/RHR8wgCdGXbCIBQVuYeMDdV5OiHqDvlQ
iqIAoIGt5HpRWtMFblSvfCp7OOgU8vzB
=rPtv
-----END PGP SIGNATURE-----