rpm spec syntax change? (was Re: Fedora i386 rawhide rebuild in mock status 2008-06-01)

[Ralf Corsepius]

On Tue, 2008-06-03 at 22:55 -0700, Alex Lancaster wrote:
> >>>>> "MD" == Matt Domsch  writes:
> 
> MD> Fedora Rawhide-in-Mock Build Results for i386 based on rawhide as
> MD> of 01-June-2008.
> 
> [...]
> 
> MD> Full logs at http://linux.dell.com/files/fedora/FixBuildRequires/
> 
> Some of these are my Perl packages:
> 
> perl-GD-SVG-0.28-4.fc9 (build/make) alexlan,perl-sig
> perl-Graph-0.84-2.fc9 (build/make) alexlan,perl-sig
> perl-SVG-2.37-1.fc9 (build/make) alexlan,perl-sig
> perl-Text-Shellwords-1.08-4.fc9 (build/make) alexlan,perl-sig
> 
> All of these builds fail during %check:
> 
> Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.54169
> + umask 022
> + cd /builddir/build/BUILD
> + cd GD-SVG-0.28
> + unset DISPLAY
> /var/tmp/rpm-tmp.54169: line 26: syntax error near unexpected token `||' 
> 
> because of the following construct in the .spec file:
> 
> %check || :
> make test
> 
> Was there a change made in rpm that makes builds fail with this
> syntax?  I didn't see any announcement and, at least at one point in
> time, I seem to recall that this was a legal and sometimes recommended
> form.  (Although I should note that I did inherit the original .spec
> files from an earlier contributor).
> 
> I assume that the solution is to just drop the "|| :" part?

Cf.: https://bugzilla.redhat.com/show_bug.cgi?id=449717

Ralf