RFE: Add -p to the diff options to provide more context in commit mails

[Kevin Fenzi]

On Thu, 23 Apr 2009 18:35:41 -0400
Chuck Ebbert <cebbert at redhat.com> wrote:

> This trivial patch adds more context to the diffs in commit mails:
> 
> --- CVSROOT.orig/syncmail
> +++ CVSROOT/syncmail
> @@ -147,7 +147,7 @@ def calculate_diff(filespec):
>          brief = ""
>          if optNoDiff:
>              brief = "--brief"
> -        diffcmd = '/usr/bin/cvs -f diff %s -kk -u -N -r %s -r %s %s'
> % (
> +        diffcmd = '/usr/bin/cvs -f diff %s -kk -u -p -N -r %s -r %s
> %s' % ( brief,
>              oldrev, newrev, file)
>          fp = os.popen(diffcmd)
> 

This looks nice to me... Since we are in a change freeze tho, we will
need to get it approved on the infrastructure list. 

Shall we just wait until after release, or would you like me to request
the change now?

kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-devel-list/attachments/20090426/fe74132d/attachment.sig>