Koji build failure with coreutils-7.5
Jeff Garzik
jgarzik at pobox.com
Mon Aug 24 07:29:45 UTC 2009
On 08/24/2009 02:26 AM, Jim Meyering wrote:
> +** Bug fixes
> +
> + cp, mv now ignore failure to preserve a symlink time stamp, when it is
> + due to their running on a kernel older than what was implied by headers
> + and libraries tested at configure time.
> +
Yeah, this will be easy to trigger for a while, unfortunately...
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -124,7 +124,13 @@ static inline int
> utimens_symlink (char const *file, struct timespec const *timespec)
> {
> #if HAVE_UTIMENSAT
> - return utimensat (AT_FDCWD, file, timespec, AT_SYMLINK_NOFOLLOW);
> + int err = utimensat (AT_FDCWD, file, timespec, AT_SYMLINK_NOFOLLOW);
> + /* When configuring on a system with new headers and libraries, and
> + running on one with a kernel that is old enough to lack the syscall,
> + utimensat fails with ENOTSUP. Ignore that. */
> + if (err&& errno == ENOSYS)
> + err = 0;
> + return err;
Seems like the comment (ENOTSUP) needs to be changed to match the code
(ENOSYS)?
Jeff
More information about the fedora-devel-list
mailing list