[Fedora-directory-commits] ldapserver/ldap/servers/plugins/uiduniq 7bit.c, 1.5, 1.5.2.1

Richard Allen Megginson (rmeggins) fedora-directory-commits at redhat.com
Thu Aug 25 21:49:50 UTC 2005


Author: rmeggins

Update of /cvs/dirsec/ldapserver/ldap/servers/plugins/uiduniq
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv9201

Modified Files:
      Tag: Directory71RtmBranch
	7bit.c 
Log Message:
Bug(s) fixed: 165600
Bug Description: Adding multiple attributes using a single ldapmodify crashes ns-slapd
Branch: Directory71RtmBranch
Reviewed by: Nathan (Thanks!)
Fix Description: In C, the array '[]' dereference operator takes precedence over the '*' deref operator.  In this case, I needed to put parentheses around the pointer dereference to avoid having array dereferenced first.  modary is a pointer to an array, not an array, so I can't dereference it with the array operator until I first dereference the pointer.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none



Index: 7bit.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/plugins/uiduniq/7bit.c,v
retrieving revision 1.5
retrieving revision 1.5.2.1
diff -u -r1.5 -r1.5.2.1
--- 7bit.c	19 Apr 2005 22:07:35 -0000	1.5
+++ 7bit.c	25 Aug 2005 21:49:47 -0000	1.5.2.1
@@ -344,7 +344,7 @@
       *modary = (LDAPMod **)slapi_ch_malloc(*capacity * sizeof(LDAPMod *));
     }
   }
-  *modary[*nmods] = toadd;
+  (*modary)[*nmods] = toadd;
   (*nmods)++;
 }
 




More information about the Fedora-directory-commits mailing list