[Fedora-directory-commits] ldapserver/ldap/servers/slapd passwd_extop.c, 1.7, 1.8

[Richard Allen Megginson (rmeggins)]

Author: rmeggins

Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv9313

Modified Files:
	passwd_extop.c 
Log Message:
Bug(s) fixed: 179723
Bug Description: crash after succesful pwdchange via ldappasswd
Reviewed by: Pete, Nathan (Thanks!)
Fix Description: The passwd_extop code does an internal operation to 
change the password.  Some of this code is only intended to be called 
for external operations where you have a conn structure.  The one place 
in particular which caused this bug is in update_pw_info, where it is 
only triggered if you must change the password or password expiration is 
in effect.  The fix is to just check to see if the pb_conn is not null.
Platforms tested: Fedora Core 4
Flag Day: no
Doc impact: no



Index: passwd_extop.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/passwd_extop.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- passwd_extop.c	15 Feb 2006 21:22:46 -0000	1.7
+++ passwd_extop.c	6 Mar 2006 20:02:06 -0000	1.8
@@ -135,7 +135,6 @@
 static int passwd_apply_mods(const char *dn, Slapi_Mods *mods) 
 {
 	Slapi_PBlock pb;
-	Slapi_Operation *operation= NULL;
 	int ret=0;
 
 	LDAPDebug( LDAP_DEBUG_TRACE, "=> passwd_apply_mods\n", 0, 0, 0 );
@@ -150,9 +149,6 @@
 		  pw_get_componentID(), /* PluginID */
 		  0); /* Flags */ 
 
-	 /* Plugin operations are INTERNAL by default, bypass it to enforce ACL checks */
-	 slapi_pblock_get (&pb, SLAPI_OPERATION, &operation);
-
 	 ret =slapi_modify_internal_pb (&pb);
   
 	 slapi_pblock_get(&pb, SLAPI_PLUGIN_INTOP_RESULT, &ret);