[Fedora-directory-commits] ldapserver/ldap/servers/slapd uuid.c, 1.6, 1.7

[Richard Allen Megginson (rmeggins)]

Author: rmeggins

Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv11789

Modified Files:
	uuid.c 
Log Message:
Resolves: bug 262021
Bug Description: Migration script does not migrate nsDS5ReplicaCredentials correctly.
Reviewed by: nhosoi (Thanks!)
Fix Description: This was a big endian vs. little endian issue.  We only use name based UUID generation with the reversible password code.  This code was not doing the ntoh with the numeric values generated.  I'm sure there is probably a compiler warning about this on some platform.
Platforms tested: RHEL5 x86_64, Solaris 9 64-bit
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none



Index: uuid.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/uuid.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- uuid.c	10 Nov 2006 23:45:40 -0000	1.6
+++ uuid.c	30 Aug 2007 00:18:10 -0000	1.7
@@ -857,9 +857,9 @@
 	memcpy(uuid, hash, sizeof(guid_t));
 
 	/* convert UUID to local byte order */
-	ntohl(uuid->time_low);
-	ntohs(uuid->time_mid);
-	ntohs(uuid->time_hi_and_version);
+	uuid->time_low = PR_ntohl(uuid->time_low);
+	uuid->time_mid = PR_ntohs(uuid->time_mid);
+	uuid->time_hi_and_version = PR_ntohs(uuid->time_hi_and_version);
 
 	/* put in the variant and version bits */
 	uuid->time_hi_and_version &= 0x0FFF;