[Fedora-directory-commits] adminserver Makefile.am, 1.21, 1.22 aclocal.m4, 1.16, 1.17 configure, 1.19, 1.20 missing, 1.10, 1.11 install-sh, 1.10, 1.11 compile, 1.9, 1.10 Makefile.in, 1.21, 1.22 depcomp, 1.10, 1.11 config.sub, 1.10, 1.11 config.guess, 1.10, 1.11

[Richard Allen Megginson (rmeggins)]

Author: rmeggins

Update of /cvs/dirsec/adminserver
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv30934/adminserver

Modified Files:
	Makefile.am aclocal.m4 configure missing install-sh compile 
	Makefile.in depcomp config.sub config.guess 
Log Message:
Resolves: bug 246683
Bug Description: Reimplement ds_create without setuputil code
Reviewed by: nhosoi (Thanks!)
Fix Description: ds_create was a CGI program that would create a new instance, set it up to be managed by console, and register it with the config ds.  The new ds_create CGI perl script does just that.  One tricky part was that, rather than enabling the pass through auth plugin and having to restart the server, the new server is created without being started, then the modification is done to the new server dse.ldif file directly, using the new FileConn.pm module, which simulates a Mozilla::LDAP::Conn on an LDIF file.  This also allows us to create a new instance with a pre-hashed rootdn password, rather than having to send the cleartext password.
I had to move around some code in AdminServer and AdminUtil so that I could use it from ds_create.  I also implemented support for the admin server PASSWORD_PIPE in perl so we could use it in other CGI perl scripts.
Finally, the error handling was not consistent in our code, so I made explicit the passing of error messages up and down the stack.  Oh how I wish we could just do this in python and use exception handling . . .
I added a test for ds_create.
Platforms tested: RHEL4
Flag Day: Yes - autotool changes
Doc impact: No.  Should work the same way as the old ds_create.



Index: Makefile.am
===================================================================
RCS file: /cvs/dirsec/adminserver/Makefile.am,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- Makefile.am	29 Jun 2007 21:29:06 -0000	1.21
+++ Makefile.am	4 Jul 2007 01:31:32 -0000	1.22
@@ -161,7 +161,7 @@
 	ds_db2bak ds_listdb ds_rmdb ds_remove ds_snmpctrl ds_vlvindex ds_addindex
 
 bin_SCRIPTS = admserv/newinst/src/register_server.pl
-cgibin_SCRIPTS = admserv/cgi-src40/Cgi.pm
+cgibin_SCRIPTS = admserv/cgi-src40/ds_create
 nodist_cmdbin_SCRIPTS = admserv/cfgstuff/start-ds-admin admserv/cfgstuff/stop-ds-admin admserv/cfgstuff/restart-ds-admin
 
 cmdbin_SCRIPTS = admserv/newinst/src/setup-ds-admin.pl \
@@ -373,7 +373,8 @@
 nodist_property_DATA = $(RESOURCE_BUNDLES_ROOT)
 # regular property files go here
 property_DATA = admserv/newinst/src/setup-ds-admin.res \
-	admserv/newinst/src/migrate-ds-admin.res
+	admserv/newinst/src/migrate-ds-admin.res \
+	admserv/cgi-src40/ds_create.res
 
 # French resource bundles (for the French localization in the future)
 #RESOURCE_BUNDLES_FR = foo_fr.res












Index: Makefile.in
===================================================================
RCS file: /cvs/dirsec/adminserver/Makefile.in,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- Makefile.in	29 Jun 2007 21:29:06 -0000	1.21
+++ Makefile.in	4 Jul 2007 01:31:32 -0000	1.22
@@ -595,7 +595,7 @@
 	admserv/newinst/src/asmigrate.map
 
 bin_SCRIPTS = admserv/newinst/src/register_server.pl
-cgibin_SCRIPTS = admserv/cgi-src40/Cgi.pm
+cgibin_SCRIPTS = admserv/cgi-src40/ds_create
 nodist_cmdbin_SCRIPTS = admserv/cfgstuff/start-ds-admin admserv/cfgstuff/stop-ds-admin admserv/cfgstuff/restart-ds-admin
 cmdbin_SCRIPTS = admserv/newinst/src/setup-ds-admin.pl \
 	admserv/newinst/src/migrate-ds-admin.pl
@@ -784,7 +784,8 @@
 nodist_property_DATA = $(RESOURCE_BUNDLES_ROOT)
 # regular property files go here
 property_DATA = admserv/newinst/src/setup-ds-admin.res \
-	admserv/newinst/src/migrate-ds-admin.res
+	admserv/newinst/src/migrate-ds-admin.res \
+	admserv/cgi-src40/ds_create.res
 
 
 # these are for the config files and scripts that we need to generate and replace