[Fedora-directory-commits] ldapserver/ldap/servers/slapd index_subsystem.c, 1.7, 1.8

[Richard Allen Megginson (rmeggins)]

Author: rmeggins

Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv3904/ldapserver/ldap/servers/slapd

Modified Files:
	index_subsystem.c 
Log Message:
Resolves: bug 297221
Bug Description: rhds71 Malformed Dynamic Authorization Group makes Directory Server Crash
Reviewed by: nhosoi (Thanks!)
Fix Description: The problem was that we were not checking the return value of slapi_str2filter().  I added a check at the crash site, and it will not print out a helpful error message.  I did a search through the code looking for other similar places and found a couple.  I added similar code in those places.
I added an initialization of a buffer to null, as suggested by nhosoi.
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no



Index: index_subsystem.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/index_subsystem.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- index_subsystem.c	18 Oct 2007 00:08:34 -0000	1.7
+++ index_subsystem.c	18 Oct 2007 22:25:14 -0000	1.8
@@ -1030,7 +1030,7 @@
 	Slapi_Filter *tmp_f = slapi_str2filter(registration_item->index_filter);
 	Slapi_Backend *be;
 	
-	if(!theCache)
+	if(!theCache || !tmp_f)
 		return -1;
 
 	index_subsys_write_lock();