[Fedora-directory-commits] ldapserver/ldap/servers/slapd/back-ldbm index.c, 1.5.2.1, 1.5.2.2

Noriko Hosoi (nhosoi) fedora-directory-commits at redhat.com
Fri Jan 11 20:05:17 UTC 2008


Author: nhosoi

Update of /cvs/dirsec/ldapserver/ldap/servers/slapd/back-ldbm
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv8765/slapd/back-ldbm

Modified Files:
      Tag: Directory71RtmBranch
	index.c 
Log Message:
Resolves: #219586
Summary: Slapi_Value memory leak in index code
Description: applied the patch to Directory71RtmBranch



Index: index.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/back-ldbm/index.c,v
retrieving revision 1.5.2.1
retrieving revision 1.5.2.2
diff -u -r1.5.2.1 -r1.5.2.2
--- index.c	26 Aug 2005 15:44:36 -0000	1.5.2.1
+++ index.c	11 Jan 2008 20:05:14 -0000	1.5.2.2
@@ -527,7 +527,8 @@
                 slapi_entry_attr_find( olde->ep_entry, mods[i]->mod_type, &curr_attr );
                 if ( mods_valueArray != NULL ) {
                     for ( j = 0; mods_valueArray[j] != NULL; j++ ) {
-                        valuearray_remove_value(curr_attr, evals, mods_valueArray[j]);
+                        Slapi_Value *rval = valuearray_remove_value(curr_attr, evals, mods_valueArray[j]);
+                        slapi_value_free( &rval );
                     }
                 }
 
@@ -541,7 +542,8 @@
                         }
                     } else {
                         /* Remove duplicate value from deleted value array */
-                        valuearray_remove_value(curr_attr, deleted_valueArray, deleted_valueArray[j]);
+                        Slapi_Value *rval = valuearray_remove_value(curr_attr, deleted_valueArray, deleted_valueArray[j]);
+                        slapi_value_free( &rval );
                         j--;
                     }
                 }
@@ -607,7 +609,8 @@
                                     }
                                 } else {
                                     /* Remove duplicate value from the mod list */
-                                    valuearray_remove_value(curr_attr, deleted_valueArray, deleted_valueArray[j]);
+                                    Slapi_Value *rval = valuearray_remove_value(curr_attr, deleted_valueArray, deleted_valueArray[j]);
+                                    slapi_value_free( &rval );
                                     j--;
                                 }
                             }




More information about the Fedora-directory-commits mailing list