[Fedora-directory-commits] dsgw/orghtml index.html, 1.1, 1.2 orgchart.tmpl.in, 1.3, 1.4 topframe.html.in, 1.2, 1.3

Thu Mar 6 22:00:42 UTC 2008

Author: rmeggins

Update of /cvs/dirsec/dsgw/orghtml
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv16950/dsgw/orghtml

Modified Files:
	index.html orgchart.tmpl.in topframe.html.in 
Log Message:
Resolves: bug 435230
Description: Clean up all HTML pages (Gateway, Org Tool, Phonebook, etc)
Fix Description: This is just the first pass.  I focused mainly on the
phonebook pages, but the C code fixes will apply to dsgw too.
The goal is to make the pages clean with HTML Tidy running in Firefox 2.
Most of the template pages had to change because they had comments like
this:
<!-- ----- comment -----
HTML 4.01 does not like this - no sequence of -- or more dashes in a comment.
The other major change was the use of & instead of just a single & in
URLs for href and img src links.  However, javascript does not like the
encoded entities, so I had to add some code to make sure we use the
unencoded form in javascript, so I added another option called "entities"
to the html template code, and added a function that will convert
encoded entities to their raw form in place.
I'm also adding some debugging shell scripts that can be used to debug
CGI programs.
Platforms tested: RHEL5 x86_64
Flag day: Yes - autotool file changes.
Doc: none yet



Index: index.html
===================================================================
RCS file: /cvs/dirsec/dsgw/orghtml/index.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2

--- index.html	11 Jan 2008 21:58:10 -0000	1.1
+++ index.html	6 Mar 2008 22:00:39 -0000	1.2
@@ -34,6 +34,8 @@
  Copyright (C) 2005 Red Hat, Inc.
  All rights reserved.
  END COPYRIGHT BLOCK -->
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN"
+    "http://www.w3.org/TR/html4/frameset.dtd">
 <HTML>
 <HEAD>
 <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
@@ -41,7 +43,7 @@
         <TITLE>Directory Server Org Chart</TITLE>
 
 
-<SCRIPT LANGUAGE="javascript">
+<SCRIPT type="text/javascript">
 
 
         var agt = navigator.userAgent.toLowerCase();


Index: orgchart.tmpl.in
===================================================================
RCS file: /cvs/dirsec/dsgw/orghtml/orgchart.tmpl.in,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- orgchart.tmpl.in	1 Feb 2008 17:04:22 -0000	1.3
+++ orgchart.tmpl.in	6 Mar 2008 22:00:39 -0000	1.4
@@ -74,7 +74,7 @@
 # the way this works now is that it will just use the LDAP server configured for the
 # phonebook to use in the pb.conf file
 
-url-phonebook-base	@httpurl@@cgiuri@/dosearch?context=pb&dn=
+url-phonebook-base	@httpurl@@cgiuri@/dosearch?context=pb&dn=
 
 #
 #   A name that has no value after it equates to "" for the value, 


Index: topframe.html.in
===================================================================
RCS file: /cvs/dirsec/dsgw/orghtml/topframe.html.in,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- topframe.html.in	28 Jan 2008 21:22:48 -0000	1.2
+++ topframe.html.in	6 Mar 2008 22:00:39 -0000	1.3
@@ -34,11 +34,13 @@
  Copyright (C) 2005 Red Hat, Inc.
  All rights reserved.
  END COPYRIGHT BLOCK -->
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"
+    "http://www.w3.org/TR/html4/strict.dtd">
 <HTML>
 <HEAD>
 <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
 <META HTTP-EQUIV="Expires" CONTENT="Thu, 01 Feb 1996 00:00:00 GMT">
-<SCRIPT LANGUAGE="javascript">
+<SCRIPT type="text/javascript">
 
 // Do the Search
 
@@ -90,16 +92,16 @@
 <TABLE BORDER="0" width="100%" cellpadding=0 cellspacing=0>
 
 <TR>
-<TD ALIGN=LEFT VALIGN=CENTER class="appName" nowrap> Directory Server Org Chart</TD>
-<TD ALIGN=LEFT VALIGN=CENTER width="75%">
+<TD align="left" valign="middle" class="appName" nowrap> Directory Server Org Chart</TD>
+<TD align="left" valign="middle" width="75%">
 		<TABLE BORDER=0>
-		<TR><TD nowrap VALIGN=CENTER ALIGN=CENTER>
+		<TR><TD nowrap valign="middle" align="center">
 		<span class="apptext">      Search for:</span>
 		</TD>
-		<TD nowrap VALIGN=CENTER>
+		<TD nowrap valign="middle">
 		<span class="apptext">
 		<FORM name="form2" Method=POST action="@cgiuri@/org" target="output_window" onsubmit="return doSearch(document.form2.data.value)">
-			<font face=\"verdana, Arial, Helvetica, sans-serif\" style=\"font-size: 12px\">
+			<font face="verdana, Arial, Helvetica, sans-serif" style="font-size: 12px">
 				<INPUT TYPE="TEXT" NAME="data" SIZE=20 MAXLENGTH=20>
 				<input type="submit" name="Submit" value="Go">
 			</font>


