[Fedora-directory-commits] adminserver/admserv/cgi-src40 security.c, 1.20, 1.21

[Richard Allen Megginson]

Author: rmeggins

Update of /cvs/dirsec/adminserver/admserv/cgi-src40
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv25778/adminserver/admserv/cgi-src40

Modified Files:
	security.c 
Log Message:
Resolves: bug 483276
Bug Description: Certificate Management: Adding Trusted CA from Console, does not save the trust flags
Reviewed by: nkinder (Thanks!)
Fix Description: In comment https://bugzilla.redhat.com/show_bug.cgi?id=483276#c13 there is a report of a memory error coming from the security CGI.  While I could not reproduce this with the latest code, I did find a minor valgrind error with a buffer size.
Platforms tested: RHEL5
Flag Day: no
Doc impact: no



Index: security.c
===================================================================
RCS file: /cvs/dirsec/adminserver/admserv/cgi-src40/security.c,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- security.c	28 Jan 2009 00:05:13 -0000	1.20
+++ security.c	10 Feb 2009 17:49:46 -0000	1.21
@@ -1260,7 +1260,8 @@
       *end = '\0';
     }
 
-    DERCert = (char*)PORT_ZAlloc(PORT_Strlen(begin));
+    DERCertLen=PORT_Strlen(begin)+1; /* +1 for trailing null */
+    DERCert = (char*)PORT_ZAlloc(DERCertLen);
 
     strcpy(DERCert, begin);
   }