[Fedora-directory-commits] ldapserver/ldap/servers/slapd modutil.c, 1.8, 1.9

[Richard Allen Megginson]

Author: rmeggins

Update of /cvs/dirsec/ldapserver/ldap/servers/slapd
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv9715/ldapserver/ldap/servers/slapd

Modified Files:
	modutil.c 
Log Message:
Resolves: bug 481223
Bug Description: Removing Group Member in ADS and Send and Receive Updates Crashes the Directory Server
Reviewed by: nkinder (Thanks!)
Fix Description: I broke this with my earlier fix about sending mods to AD.  There are calls which reset the raw entry from AD before the call to mod_already_made.  The fix is to only retrieve the raw entry just before we use it, after it may have been reset. I also found a memory leak in the mod init with valueset function I added for the prior fix.
Platforms tested: RHEL5
Flag Day: no
Doc impact: no



Index: modutil.c
===================================================================
RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/modutil.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- modutil.c	9 Jan 2009 21:30:56 -0000	1.8
+++ modutil.c	26 Jan 2009 17:35:15 -0000	1.9
@@ -603,6 +603,8 @@
 	slapi_mod_set_type (smod, type);
 	if (svs!=NULL) {
 		Slapi_Value **svary = valueset_get_valuearray(svs);
+		ber_bvecfree(smod->mod->mod_bvalues);
+		smod->mod->mod_bvalues = NULL;
 		valuearray_get_bervalarray(svary, &smod->mod->mod_bvalues);
 		smod->num_values = slapi_valueset_count(svs);
 		smod->num_elements = smod->num_values + 1;