[389-commits] Re: [389-devel] Please review: Add update code - make setup-ds.pl -u do updates

Rich Megginson rmeggins at redhat.com
Mon Sep 21 19:22:28 UTC 2009


Noriko Hosoi wrote:
> On 09/17/2009 04:12 PM, Rich Megginson wrote:
>>
>> ------------------------------------------------------------------------
>>
>> --
>> 389-devel mailing list
>> 389-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>>   
> Hi Rich,
>
> I noticed these 2 minor things.  Other than these, your patch looks good.
Thanks.  Fixed and pushed to master.
To ssh://git.fedorahosted.org/git/389/ds.git
   2de80f5..cc89083  master -> master
commit cc89083f1177606d4cbbb52f8cdc5e34d0d16f70
Author: Rich Megginson <rmeggins at redhat.com>
Date:   Wed Sep 9 17:01:49 2009 -0600

    Add update code - make setup-ds.pl -u do updates

>
> diff --git a/ldap/admin/src/scripts/Setup.pm.in 
> b/ldap/admin/src/scripts/Setup.pm.in
> index 7ad57c1..f314d67 100644
> --- a/ldap/admin/src/scripts/Setup.pm.in
> +++ b/ldap/admin/src/scripts/Setup.pm.in
> @@ -142,6 +145,7 @@ sub init {
>      $self->{keep} = $keep;
>      $self->{preonly} = $preonly;
>      $self->{update} = $update;
> +    $self->{force} = *$update;* <== could this be "$force"?
>      $self->{logfile} = $logfile;
>      $self->{log} = new SetupLog($self->{logfile});
>      # if user supplied inf file, use that to initializ
>
>
> diff --git a/ldap/admin/src/scripts/dsupdate.map.in 
> b/ldap/admin/src/scripts/dsupdate.map.in
> new file mode 100644
> +# Copyright (C) *2007* Red Hat, Inc. <== 2009? :)
> +# All rights reserved.
> +# END COPYRIGHT BLOCK
>
> --noriko
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-commits/attachments/20090921/6a2094a0/attachment.bin>


More information about the Fedora-directory-commits mailing list