[Fedora-directory-devel] Please review: Bug 215669: Define LIBDIR, BINDIR, etc. in Makefile

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215669
Bug(s) fixed: 215669
Bug Description: Define LIBDIR, BINDIR, etc. in Makefile
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: The paths LIBDIR, BINDIR, et. al. are #define'd in 
create_instance.h to hard coded values.  We should be able to set these 
values in configure and override the built in values.  We can't simply 
set them via AC_DEFINE in configure.ac because we are using config.h and 
this would render the definition like this:
#define BINDIR "${exec_prefix}/bin"
instead of
#define BINDIR "/usr/bin"
So we instead define them in Makefile.am and add their definitions to 
AM_CPPFLAGS, and quote them properly to make sure the value includes the 
quotation marks when expanded in the C code.  I tested this with both an 
rpmbuild and a regular developer type build.
Platforms tested: RHEL4/FC5
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141220&action=diff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3178 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20061114/7c6623ea/attachment.bin>