[Fedora-directory-devel] Please review (revised): [Bug 208672] parameterizing the hardcoded paths (phase 2. db, log, lock, pid dir)
Noriko Hosoi
nhosoi at redhat.com
Wed Oct 4 00:16:10 UTC 2006
Hello,
After discussing with Nathan, I've removed nsslapd-dbdir and
nsslapd-ldifdir from cn=config, which are redundant.
Your review would be greatly appreciated.
Thanks,
--noriko
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208672
Summary: parameterizing the hardcoded paths (phase 2. db, log,
lock, pid dir)
Product: Fedora Directory Server
Version: 1.0.2
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Directory Server
AssignedTo: nhosoi at redhat.com
ReportedBy: nhosoi at redhat.com
QAContact: ohegarty at redhat.com
CC: ohegarty at redhat.com
------- Additional Comments From nhosoi at redhat.com 2006-10-03 19:45 EST -------
Created an attachment (id=137712)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=137712&action=view)
cvs diffs (ldapserver -- revised)
Thanks for the comments and the discussion, Nathan.
Here's the additional changes:
1) I re-thought about the 2 issues and have decided to get rid of nsslapd-dbdir
and nsslapd-ldifdir from cn=config. Instead of referring nsslapd-dbdir, we can
use nsslapd-directory in cn=config,cn=ldbm database,cn=plugins,cn=config. And
for nsslapd-ldifdir, it's basically "defined" in db2ldif, where you can get the
location info.
2) In terms of db2ldif and db2ldif.pl, I added server_id prefix to the default
exported file name. Before, each instance had its own ldif dir, but under HFS,
there is one ldif directory shared among servers on one host. To make it
easier to know the origin of the ldif, I propose to add <server_id>- in front
of the generated ldif file name like this:
<prefix>/share/fedora-ds/ldif/<serverID>-2006_10_03_162640.ldif
3) In the same token, when another instance is added to an existing server
sharing the same directory structure, default ldif files such as Example.ldif
and Example-roles.ldif files are overwritten. So, I added a backup code to
keep the existing files. (note that if the file having the extension ".bak"
already exists, the file is overridden...)
Files:
ldap/admin/include/dsalib.h
ldap/admin/lib/dsalib_db.c
ldap/admin/lib/dsalib_location.c
ldap/admin/lib/dsalib_util.c
ldap/admin/src/create_instance.c
ldap/admin/src/create_instance.h
ldap/admin/src/ds_remove.c
ldap/admin/src/scripts/template-db2ldif.pl
ldap/servers/slapd/libglobs.c
ldap/servers/slapd/protect_db.c
ldap/servers/slapd/proto-slap.h
ldap/servers/slapd/slap.h
ldap/servers/slapd/snmp_collator.c
ldap/servers/slapd/back-ldbm/ldbm_config.c
ldap/servers/slapd/back-ldbm/ldbm_config.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3170 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20061003/ce59109e/attachment.bin>
More information about the Fedora-directory-devel
mailing list