[Fedora-directory-devel] Please review: Bug 229825: aci with bogus uid= dn created by ds_newinst

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229825
Resolves: bug 229825
Bug Description: aci with bogus uid= dn created by ds_newinst
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: Unknown to me until just now, PL_strdup(NULL) will 
return "" - the empty string.  The code in config_suitespot() expects 
that empty or unused fields are NULL.  The solution is to create a 
create_instance_strdup() wrapper around PL_strdup() and use that in 
cases where the argument may be NULL.  I checked create_instance.c.  
Every other place where PL_strdup is used, the argument is checked for 
NULL first.  So these are the only places affected.  Instance creation 
works fine after this change and does not create the offending aci.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=148687&action=diff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070223/7093f34d/attachment.bin>