[Fedora-directory-devel] Please review: Bug 246683: Reimplement ds_create without setuputil code

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246683
Resolves: bug 246683
Bug Description: Reimplement ds_create without setuputil code
Reviewed by: ???
Files: new files
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158484
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158486
Branch: HEAD
Fix Description: ds_create was a CGI program that would create a new 
instance, set it up to be managed by console, and register it with the 
config ds.  The new ds_create CGI perl script does just that.  One 
tricky part was that, rather than enabling the pass through auth plugin 
and having to restart the server, the new server is created without 
being started, then the modification is done to the new server dse.ldif 
file directly, using the new FileConn.pm module, which simulates a 
Mozilla::LDAP::Conn on an LDIF file.  This also allows us to create a 
new instance with a pre-hashed rootdn password, rather than having to 
send the cleartext password.
I had to move around some code in AdminServer and AdminUtil so that I 
could use it from ds_create.  I also implemented support for the admin 
server PASSWORD_PIPE in perl so we could use it in other CGI perl scripts.
Finally, the error handling was not consistent in our code, so I made 
explicit the passing of error messages up and down the stack.  Oh how I 
wish we could just do this in python and use exception handling . . .
I added a test for ds_create.
Platforms tested: RHEL4
Flag Day: Yes - autotool changes
Doc impact: No.  Should work the same way as the old ds_create.
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158485&action=diff
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158487&action=diff
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/fedora-directory-devel/attachments/20070703/953c515f/attachment.bin>